Update README.md #37
Merged
Update README.md #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 14, 2018 14:40
added note about recompiling deps after adding config for originator
joshchernoff
commented
Feb 15, 2018
lib/paper_trail.ex
Outdated
| Multi.new | ||
| |> Multi.run(:initial_version, fn %{} -> | ||
| version_id = get_sequence_id("versions") + 1 | ||
| changeset_data = case Map.get(changeset, :data) do |
There was a problem hiding this comment.
This condition is not required because Map.get can return a default value which if you provide changeset as the default it does the same thing as this condition.
|
I will auto-format my library code with elixir 1.6 formatter and then investigate this pull request. |
|
I just made a format change could you merge my master to your branch to remove the conflict? |
|
The changes look good, once you fix the merge conflict I will merge this and cut a new release. Thanks for your contribution. |
|
I fixed the merge conflict and released this on 0.7.9, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added note about recompiling deps after adding config for originator
address #36